From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/4] xfstests: add _require_attrs
Date: Thu, 21 Oct 2010 01:02:03 -0400 [thread overview]
Message-ID: <20101021050202.GA1752@infradead.org> (raw)
In-Reply-To: <1287597791.2284.99.camel@doink>
On Wed, Oct 20, 2010 at 01:03:11PM -0500, Alex Elder wrote:
> On Fri, 2010-10-15 at 18:29 -0400, Christoph Hellwig wrote:
> > Add a new helper to check if extended attributes are supported. It
> > errors out if any of the attr tools are not found, or if a filesystem
> > does not support setting attributes.
> >
> > Remove the opencoded checks for the attr tools from various tests
> > now that we do them in common code.
>
> Generally this looks good.
>
> I was going to just make a few suggestions and ask you
> to fix them before committing, but I think there are
> enough that I think it would be good to re-submit this.
I'd rather commit the patch as-is and fix up the attr/getfattr
references separately. I'll submit a patch to do ASAP.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-10-21 5:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 22:28 [PATCH 0/4] xfstests fixes for hfsplus Christoph Hellwig
2010-10-15 22:28 ` [PATCH 1/4] xfstests: fix _require_acl Christoph Hellwig
2010-10-20 17:35 ` Alex Elder
2010-10-15 22:29 ` [PATCH 2/4] xfstests: add _require_attrs Christoph Hellwig
2010-10-20 18:03 ` Alex Elder
2010-10-21 5:02 ` Christoph Hellwig [this message]
2010-10-21 12:49 ` Alex Elder
2010-10-15 22:29 ` [PATCH 3/4] xfstests: fix quota detection Christoph Hellwig
2010-10-20 17:36 ` Alex Elder
2010-10-15 22:29 ` [PATCH 4/4] xfstests: handle filesystems without FIEMAP support Christoph Hellwig
2010-10-20 17:37 ` Alex Elder
2010-10-21 5:05 ` Christoph Hellwig
2010-10-21 5:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021050202.GA1752@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox