From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, Alex Elder <aelder@sgi.com>
Subject: Re: [PATCH 4/4] xfstests: handle filesystems without FIEMAP support
Date: Thu, 21 Oct 2010 16:35:29 +1100 [thread overview]
Message-ID: <20101021053529.GR32255@dastard> (raw)
In-Reply-To: <20101021050531.GB1752@infradead.org>
On Thu, Oct 21, 2010 at 01:05:31AM -0400, Christoph Hellwig wrote:
> On Wed, Oct 20, 2010 at 12:37:01PM -0500, Alex Elder wrote:
> > Looks good, but I think if the operation is not
> > supported you want to delete both "${fiemapfile}"
> > and "${fiemaplog}".
> >
> > While you're at it, make use of the "${fiemapfile}"
> > variable in the fiemap-tester command... (This
> > appears to be a bug in the original test.)
>
> Updated version below:
>
> ---
> From: Christoph Hellwig <hch@lst.de>
> Subject: [PATCH 4/4] xfstests: handle filesystems without FIEMAP support
>
> Do a _notrun in 225 if we get EOPNOSUPP back from FIEMAP instead
> of failing the test.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-10-21 5:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 22:28 [PATCH 0/4] xfstests fixes for hfsplus Christoph Hellwig
2010-10-15 22:28 ` [PATCH 1/4] xfstests: fix _require_acl Christoph Hellwig
2010-10-20 17:35 ` Alex Elder
2010-10-15 22:29 ` [PATCH 2/4] xfstests: add _require_attrs Christoph Hellwig
2010-10-20 18:03 ` Alex Elder
2010-10-21 5:02 ` Christoph Hellwig
2010-10-21 12:49 ` Alex Elder
2010-10-15 22:29 ` [PATCH 3/4] xfstests: fix quota detection Christoph Hellwig
2010-10-20 17:36 ` Alex Elder
2010-10-15 22:29 ` [PATCH 4/4] xfstests: handle filesystems without FIEMAP support Christoph Hellwig
2010-10-20 17:37 ` Alex Elder
2010-10-21 5:05 ` Christoph Hellwig
2010-10-21 5:35 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021053529.GR32255@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox