* [PATCH] xfstests: remove dead code in test 062
@ 2010-10-21 20:07 Christoph Hellwig
2010-10-21 21:25 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2010-10-21 20:07 UTC (permalink / raw)
To: xfs
The _linux_attr_calls function is never called, remove it.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/062
===================================================================
--- xfstests-dev.orig/062 2010-10-21 19:57:24.000000000 +0000
+++ xfstests-dev/062 2010-10-21 19:58:34.000000000 +0000
@@ -51,47 +51,6 @@ _filter_scratch()
sed -e "s,$SCRATCH_MNT,SCRATCH_MNT,g"
}
-_linux_attr_calls()
-{
- echo "*** set/get one initially empty attribute"
- setfattr -h -n $nsp.name $SCRATCH_MNT/$inode
- getfattr -m $nsp $SCRATCH_MNT/$inode
-
- echo "*** overwrite empty, set several new attributes"
- setfattr -h -n $nsp.name -v 0xbabe $SCRATCH_MNT/$inode
- setfattr -h -n $nsp.name2 -v 0xdeadbeef $SCRATCH_MNT/$inode
- setfattr -h -n $nsp.name3 -v 0xdeface $SCRATCH_MNT/$inode
-
- echo "*** fetch several attribute names and values (hex)"
- getfattr -m $nsp -e hex $SCRATCH_MNT/$inode
-
- echo "*** fetch several attribute names and values (base64)"
- getfattr -m $nsp -e base64 $SCRATCH_MNT/$inode
-
- echo "*** shrink value of an existing attribute"
- setfattr -h -n $nsp.name2 -v 0xdeaf $SCRATCH_MNT/$inode
- getfattr -m $nsp -e hex $SCRATCH_MNT/$inode
-
- echo "*** grow value of existing attribute"
- setfattr -h -n $nsp.name2 -v 0xdecade $SCRATCH_MNT/$inode
- getfattr -m $nsp -e hex $SCRATCH_MNT/$inode
-
- echo "*** set an empty value for second attribute"
- setfattr -h -n $nsp.name2 $SCRATCH_MNT/$inode
- getfattr -m $nsp -n $nsp.name2 $SCRATCH_MNT/$inode
-
- echo "*** overwrite empty value"
- setfattr -h -n $nsp.name2 -v 0xcafe $SCRATCH_MNT/$inode
- getfattr -m $nsp -e hex -n $nsp.name2 $SCRATCH_MNT/$inode
-
- echo "*** remove attribute"
- setfattr -h -x $nsp.name2 $SCRATCH_MNT/$inode
- getfattr -m $nsp -e hex -n $nsp.name2 $SCRATCH_MNT/$inode
-
- echo "*** final list (strings, type=$inode, nsp=$nsp)"
- getfattr -m '.' -e hex $SCRATCH_MNT/$inode
-}
-
getfattr()
{
$GETFATTR_PROG --absolute-names -dh $@ 2>&1 | _filter_scratch
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] xfstests: remove dead code in test 062
2010-10-21 20:07 [PATCH] xfstests: remove dead code in test 062 Christoph Hellwig
@ 2010-10-21 21:25 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2010-10-21 21:25 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Thu, 2010-10-21 at 16:07 -0400, Christoph Hellwig wrote:
> The _linux_attr_calls function is never called, remove it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Alex Elder <aelder@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-21 21:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-21 20:07 [PATCH] xfstests: remove dead code in test 062 Christoph Hellwig
2010-10-21 21:25 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox