From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: xfstests: use a common _filter_scratch function
Date: Fri, 22 Oct 2010 07:48:55 -0400 [thread overview]
Message-ID: <20101022114855.GA13867@infradead.org> (raw)
In-Reply-To: <201010211900.o9LJ086G002762@stout.americas.sgi.com>
On Thu, Oct 21, 2010 at 02:00:08PM -0500, Alex Elder wrote:
> There are a number of tests that use a shell function called
> "filter_scratch" or "_filter_scratch" in order to have the actual
> scratch device or mount point show up in test output with a symbolic
> name. There are two sets, each following a slightly different
> convention. Put a common _filter_scratch function definition in
> "common.filter" and have all test scripts use that instead.
> Choosing one of the two conventions meant that a few test output
> files had to be changed.
>
> In addition, add a call to _filter_scratch to test 185, and update
> its output accordingly.
Looks good. It might be worth to add a TEST_DIR filter for completeness
as well.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-10-22 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 19:00 xfstests: use a common _filter_scratch function Alex Elder
2010-10-22 11:48 ` Christoph Hellwig [this message]
2010-10-25 13:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022114855.GA13867@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox