From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: use a common _filter_test_dir function
Date: Mon, 25 Oct 2010 09:45:43 -0400 [thread overview]
Message-ID: <20101025134542.GC4235@infradead.org> (raw)
In-Reply-To: <201010221409.o9ME9OTQ003885@stout.americas.sgi.com>
On Fri, Oct 22, 2010 at 09:09:24AM -0500, Alex Elder wrote:
> Christoph Hellwig suggested that a function similar to the common
> "_filter_scratch" function ought to be created to handle filtering
> of the TEST_DIR and TEST_DEV variables. This patch implements that.
>
> The name "_filter_test" seems like it might suggest it does
> something different, so I'm calling this one "_filter_test_dir".
> This unfortunately makes the "test" and "scratch" functions have
> different naming conventions, but I guess we should be accustomed
> to that by now (consider "TEST_DIR" and "SCRATCH_MNT").
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-10-25 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 14:09 [PATCH] xfstests: use a common _filter_test_dir function Alex Elder
2010-10-25 13:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025134542.GC4235@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox