From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH 3/3] xfs: use hlist_add_fake
Date: Sat, 6 Nov 2010 07:43:08 -0400 [thread overview]
Message-ID: <20101106114308.GD25395@infradead.org> (raw)
In-Reply-To: <20101106114226.GA25395@infradead.org>
XFS does not need it's inodes to actuall be hashed in the VFS inode cache, but
we require the inode to be marked hashed for the writeback code to work.
Insted of using insert_inode_hash, which requires a second inode_lock roundtrip
after the partial merge of the inode scalability patches in 2.6.37-rc simply
use the new hlist_add_fake helper to mark it hashed without requiring a lock
or touching a global cache line.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: linux-2.6/fs/xfs/linux-2.6/xfs_iops.c
===================================================================
--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_iops.c 2010-11-05 19:17:18.511013308 +0100
+++ linux-2.6/fs/xfs/linux-2.6/xfs_iops.c 2010-11-05 19:23:31.772029658 +0100
@@ -762,7 +762,8 @@ xfs_setup_inode(
inode->i_state = I_NEW;
inode_sb_list_add(inode);
- insert_inode_hash(inode);
+ /* make the inode look hashed for the writeback code */
+ hlist_add_fake(&inode->i_hash);
inode->i_mode = ip->i_d.di_mode;
inode->i_nlink = ip->i_d.di_nlink;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-11-06 11:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 11:42 a few patches for 2.6.37 Christoph Hellwig
2010-11-06 11:42 ` [PATCH 1/3] xfs: tell lockdep about parent iolock usage in filestreams Christoph Hellwig
2010-11-06 11:42 ` [PATCH 2/3] xfs: fix a few compiler warnings with CONFIG_XFS_QUOTA=n Christoph Hellwig
2010-11-06 17:51 ` Andi Kleen
2010-11-06 17:56 ` Christoph Hellwig
2010-11-06 11:43 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101106114308.GD25395@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox