public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfs: fix a few compiler warnings with CONFIG_XFS_QUOTA=n
Date: Sat, 6 Nov 2010 13:56:31 -0400	[thread overview]
Message-ID: <20101106175631.GA13315@infradead.org> (raw)
In-Reply-To: <87aalmtk66.fsf@basil.nowhere.org>

On Sat, Nov 06, 2010 at 06:51:29PM +0100, Andi Kleen wrote:
> Christoph Hellwig <hch@infradead.org> writes:
> 
> > Andi Kleen reported that gcc-4.5 gives lots of warnings for him inside the
> > XFS code.  It turned out most of them are due to the quota stubs beeing
> > macros, and gcc now complaining about macros evaluating to 0 that are not
> > assigned to variables.
> 
> Thanks. BTW I believe this was already fixed in my big warning patchkit
> from some time ago, unfortunately that didn't make it in :-/
> 
> A gcc 4.6 build is also still incredibly noisy.

I'll tacked the dir warnings your reported next, and after that I'll
look into more of the gcc 4.6 warnings. But that's 2.6.38 material,
while this one is simple enough to still sneak it into 2.6.37.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-11-06 17:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 11:42 a few patches for 2.6.37 Christoph Hellwig
2010-11-06 11:42 ` [PATCH 1/3] xfs: tell lockdep about parent iolock usage in filestreams Christoph Hellwig
2010-11-06 11:42 ` [PATCH 2/3] xfs: fix a few compiler warnings with CONFIG_XFS_QUOTA=n Christoph Hellwig
2010-11-06 17:51   ` Andi Kleen
2010-11-06 17:56     ` Christoph Hellwig [this message]
2010-11-06 11:43 ` [PATCH 3/3] xfs: use hlist_add_fake Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101106175631.GA13315@infradead.org \
    --to=hch@infradead.org \
    --cc=andi@firstfloor.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox