Re: [PATCH 08/16] xfs: convert pag_ici_lock to a spin lock

Christoph Hellwig
2010-11-08T23:08:52Z

On Mon, Nov 08, 2010 at 07:55:11PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> now that we are using RCU protection for the inode cache lookups,
> the lock is only needed on the modification side. Hence it is not
> necessary for the lock to be a rwlock as there are no read side
> holders anymore. Convert it to a spin lock to reflect it's exclusive
> nature.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Reviewed-by: Alex Elder <aelder@sgi.com>

Looks good, and this will make Thomas happy given that XFS is now
rwlock_t-free.

Reviewed-by: Christoph Hellwig <hch@lst.de>