Re: [PATCH 02/16] xfs: move delayed write buffer trace

Christoph Hellwig
2010-11-08T09:23:10Z

On Mon, Nov 08, 2010 at 07:55:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The delayed write buffer split trace currently issues a trace for
> every buffer it scans. These buffers are not necessarily queued for
> delayed write. Indeed, when buffers are pinned, there can be
> thousands of traces of buffers that aren't actually queued for
> delayed write and the ones that are are lost in the noise. Move the
> trace point to record only buffers that are split out for IO to be
> issued on.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>