Re: [PATCH 11/16] xfs: connect up buffer reclaim priority hooks

Dave Chinner
2010-11-08T23:49:28Z

On Mon, Nov 08, 2010 at 06:25:09AM -0500, Christoph Hellwig wrote:
> > +/*
> > + * buffer types
> > + */
> > +#define B_FS_DQUOT 1
> > +#define B_FS_AGFL 2
> > +#define B_FS_AGF 3
> > +#define B_FS_ATTR_BTREE 4
> > +#define B_FS_DIR_BTREE 5
> > +#define B_FS_MAP 6
> > +#define B_FS_INOMAP 7
> > +#define B_FS_AGI 8
> > +#define B_FS_INO 9
>
> Is there any good reason to keep/reintroduce the buffer types? In this
> series we're only using the refcounts, and I can't see any good use for
> the types either.

I just wanted to use the existing hooks without modifying them to be
plain "set reference" hooks. I'm not really fussed - this was just
the simplest way to get the hookѕ working.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com