From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add _require_sparse_files
Date: Tue, 9 Nov 2010 23:00:36 +1100 [thread overview]
Message-ID: <20101109120036.GM2715@dastard> (raw)
In-Reply-To: <20101109113453.GA21237@infradead.org>
On Tue, Nov 09, 2010 at 06:34:54AM -0500, Christoph Hellwig wrote:
> updated version to also include test 239 which reqires the check, too.
>
> ---
> From: Christoph Hellwig <hch@lst.de>
> Subject: [PATCH] xfstests: add _require_sparse_files
>
> Add a helper to check if the filesystem supports sparse files. This is
> used to guard tests that exercise sparse file functionality and would
> take forever on filesystems that have to zero all blocks on extending
> truncates.
>
> Unfortunately there's no good way to autodetect this functionality, so
> just implement it as a blacklist for now.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok, minor typo needs fixing, but:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
> +#
> +# Check if the filesystem supports sparese files.
sparse
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-11-09 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 12:34 [PATCH] xfstests: add _require_sparse_files Christoph Hellwig
2010-11-09 11:34 ` Christoph Hellwig
2010-11-09 12:00 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109120036.GM2715@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox