From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH, RFC] xfs: fix failed write handling
Date: Tue, 9 Nov 2010 08:55:20 -0500 [thread overview]
Message-ID: <20101109135520.GA7418@infradead.org> (raw)
In-Reply-To: <20101109113530.GK2715@dastard>
> @@ -1020,6 +974,7 @@ out_invalidate:
> return;
> }
>
> +
> /*
> * Write out a dirty page.
> *
Spurious whitespace change.
> +int
> +xfs_bmap_punch_delalloc_range(
> + struct xfs_inode *ip,
> + xfs_fileoff_t start,
> + ssize_t end)
Making this helper work in terms of FSBs seem a lot cleaner than
making it work in terms of bytes. Both callers already deal with
FSBs, as does xfs_bunmapi.
Otherwise looks good to me.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-11-09 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 0:26 [PATCH, RFC] xfs: fix failed write handling Christoph Hellwig
2010-11-09 5:51 ` Dave Chinner
2010-11-09 11:35 ` Dave Chinner
2010-11-09 13:55 ` Christoph Hellwig [this message]
2010-11-17 9:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109135520.GA7418@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox