From: Christoph Hellwig <hch@infradead.org>
To: Ajeet Yadav <ajeet.yadav.77@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-mips@linux-mips.org, "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: XFS mounting fails on MIPS
Date: Tue, 9 Nov 2010 09:05:28 -0500 [thread overview]
Message-ID: <20101109140527.GA13041@infradead.org> (raw)
In-Reply-To: <AANLkTinqK-HvuHPeaTgxJOJuWMfomP2C12G=uVcqhWdn@mail.gmail.com>
Hi Ajeet,
On Tue, Nov 09, 2010 at 04:43:04PM +0530, Ajeet Yadav wrote:
> True, its the same system and you were right it was cache VIPT cache problem
> the cache hold the stale value even after xlog_bread() update the buffer.
> I do not know whether its correct ways to resolve the problem, but the
> problem no longer occur.
It seems like you more less re-implemented the vmap coherency hooks
inside XFS, hardcoded to the mips implementation.
The actual helpers would looks something like:
static inline void flush_kernel_vmap_range(void *addr, int size)
{
dma_cache_inv(addr, size);
}
static inline void invalidate_kernel_vmap_range(void *addr, int size)
{
dma_cache_inv(addr, size);
}
For some reason the kernel also expects flush_dcache_page to be
implemented by an architecture if we want to implement these two
(it's keyed off ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE).
Can someone of the mips folks helps with this?
The testcase is easy, mounting an xfs filesystem after an unclean
shutdown on a machine with virtually indexed caches.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-11-09 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-04 5:57 XFS mounting fails on MIPS Ajeet Yadav
2010-11-04 10:23 ` Stan Hoeppner
2010-11-04 12:40 ` Dave Chinner
2010-11-04 12:50 ` Christoph Hellwig
2010-11-09 11:13 ` Ajeet Yadav
2010-11-09 14:05 ` Christoph Hellwig [this message]
2010-11-11 4:57 ` Ajeet Yadav
2010-11-11 5:40 ` Ajeet Yadav
2010-11-11 12:49 ` Christoph Hellwig
2010-11-11 14:56 ` Ajeet Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109140527.GA13041@infradead.org \
--to=hch@infradead.org \
--cc=ajeet.yadav.77@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox