From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Marius Tolzmann <tolzmann@molgen.mpg.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: check block truncation after write failure
Date: Wed, 10 Nov 2010 09:34:26 +1100 [thread overview]
Message-ID: <20101109223426.GO2715@dastard> (raw)
In-Reply-To: <20101109114923.GA29629@infradead.org>
On Tue, Nov 09, 2010 at 06:49:23AM -0500, Christoph Hellwig wrote:
> Extraced from https://bugzilla.kernel.org/show_bug.cgi?id=22452
> "data corruption after mmap()ing a file and writev() some data to another file"
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good. One comment below....
Reviewed-by: Dave Chinner <david@fromorbit.com>
> +{
> + rm -rf $file
> + rm -rf $file.NEW
> +}
> +
> +trap "_cleanup ; exit \$status" 0 1 2 3 15
> +
> +echo -n "cccccccccc" > $file
> +$here/src/t_mmap_writev $file $file.NEW
> +xxd $file.NEW
xxd - on debian that's packaged in the vim-common package, which
not everyone will have installed (e.g. emacs users ;).
Better to use 'od -Ax' as od is part of coreutils and already used
in other qa tests so we don't introduce a new external dependency...
CHeers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-11-09 22:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 11:49 [PATCH] xfstests: check block truncation after write failure Christoph Hellwig
2010-11-09 22:34 ` Dave Chinner [this message]
2010-11-10 12:55 ` Christoph Hellwig
2010-11-17 9:17 ` Christoph Hellwig
2010-11-19 14:53 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101109223426.GO2715@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=tolzmann@molgen.mpg.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox