public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jeffrey Hundstad <jeffrey.hundstad@mnsu.edu>
Cc: xfs@oss.sgi.com
Subject: Re: WARNING: at fs/xfs/linux-2.6/xfs_aops.c:1289 xfs_vm_releasepage+0x32/0x41()
Date: Wed, 17 Nov 2010 04:58:15 -0500	[thread overview]
Message-ID: <20101117095815.GA5531@infradead.org> (raw)
In-Reply-To: <4CE33550.1040302@mnsu.edu>

On Tue, Nov 16, 2010 at 07:52:16PM -0600, Jeffrey Hundstad wrote:
> Hello,
> 
> I'm not sure if this is interesting at all.  Let me know if it is, I
> can do bisects if needed, let me know which config additions you
> need for debugging.

It's very interesting.  I put these WARN_ONs in because we believed we
could never get a releasepage call with delayed or unwritten extents
still on.  Previous it could happen during truncate, but with the new
truncate sequence that should be gone.  Your trace on the other hand
comes from kswapd.

>  [<c1019687>] ? warn_slowpath_common+0x7c/0x8f
>  [<c10dbdcc>] ? xfs_vm_releasepage+0x32/0x41
>  [<c10dbdcc>] ? xfs_vm_releasepage+0x32/0x41
>  [<c10196b5>] ? warn_slowpath_null+0x1b/0x1e
>  [<c10dbdcc>] ? xfs_vm_releasepage+0x32/0x41
>  [<c1046672>] ? try_to_release_page+0x2c/0x3c
>  [<c104fc12>] ? shrink_page_list+0x47d/0x5e3
>  [<c104ea7a>] ? isolate_lru_pages+0x64/0x1cf
>  [<c104fee4>] ? shrink_inactive_list+0x16c/0x1f3
>  [<c1050272>] ? shrink_zone+0x307/0x3af
>  [<c10506c6>] ? kswapd+0x3ac/0x574
>  [<c102b335>] ? autoremove_wake_function+0x0/0x31
>  [<c105031a>] ? kswapd+0x0/0x574
>  [<c102b15f>] ? kthread+0x62/0x67
>  [<c102b0fd>] ? kthread+0x0/0x67
>  [<c1002b16>] ? kernel_thread_helper+0x6/0x10

This looks like some sort of race between writepage and redirtying.

Let me think about it a bit more, but I think it's harmless.  What
worries me more is that aptitude is apparently able to trigger
kswapd writeback easily.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-11-17  9:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-17  1:52 WARNING: at fs/xfs/linux-2.6/xfs_aops.c:1289 xfs_vm_releasepage+0x32/0x41() Jeffrey Hundstad
2010-11-17  9:58 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117095815.GA5531@infradead.org \
    --to=hch@infradead.org \
    --cc=jeffrey.hundstad@mnsu.edu \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox