public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Lachlan McIlroy <lmcilroy@redhat.com>,
	xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests 246: Test for race between direct I/O and mmap
Date: Thu, 18 Nov 2010 16:36:23 +1100	[thread overview]
Message-ID: <20101118053623.GU13830@dastard> (raw)
In-Reply-To: <4CDDC193.9030208@redhat.com>

On Fri, Nov 12, 2010 at 04:37:07PM -0600, Eric Sandeen wrote:
> 
> 
> From: Lachlan McIlroy <lmcilory@redhat.com>
> 
> A customer reported a problem:
> 
> If a process is using mmap to write to a file on an 
> ext4 filesystem while another process is using direct 
> I/O to write to the same file the first thread may 
> receive a SIGBUS during a page fault.
> 
> A SIGBUS occurs if the page fault tries to access a 
> page that is entirely beyond the end of the file but 
> in this test case that should not be happening.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---

looks fine to me.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2010-11-18  5:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12 22:37 [PATCH] xfstests 246: Test for race between direct I/O and mmap Eric Sandeen
2010-11-15  1:01 ` Lachlan McIlroy
2010-11-15  3:57   ` Eric Sandeen
2010-11-18  5:36 ` Dave Chinner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101118053623.GU13830@dastard \
    --to=david@fromorbit.com \
    --cc=lmcilroy@redhat.com \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox