* [PATCH] xfstests 246: Test for race between direct I/O and mmap
@ 2010-11-12 22:37 Eric Sandeen
2010-11-15 1:01 ` Lachlan McIlroy
2010-11-18 5:36 ` Dave Chinner
0 siblings, 2 replies; 4+ messages in thread
From: Eric Sandeen @ 2010-11-12 22:37 UTC (permalink / raw)
To: xfs mailing list; +Cc: Lachlan McIlroy
From: Lachlan McIlroy <lmcilory@redhat.com>
A customer reported a problem:
If a process is using mmap to write to a file on an
ext4 filesystem while another process is using direct
I/O to write to the same file the first thread may
receive a SIGBUS during a page fault.
A SIGBUS occurs if the page fault tries to access a
page that is entirely beyond the end of the file but
in this test case that should not be happening.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
#! /bin/bash
# FS QA Test No. 246
#
# Test for race between direct I/O and mmap
#
#-----------------------------------------------------------------------
# Copyright (c) 2010 Red Hat, Inc. All Rights Reserved.
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License as
# published by the Free Software Foundation.
#
# This program is distributed in the hope that it would be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
#-----------------------------------------------------------------------
#
# creator
owner=lmcilroy@redhat.com
seq=`basename $0`
echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
trap "_cleanup; exit \$status" 0 1 2 3 7 15
_cleanup()
{
cd /
rm -f $tmp.* $testfile
wait
}
# get standard environment, filters and checks
. ./common.rc
. ./common.filter
# real QA test starts here
# Modify as appropriate.
_supported_fs generic
_supported_os Linux
testfile=$TEST_DIR/$seq.$$
loops=500
iosize=1048576
# Initialise file
dd if=/dev/zero of=$testfile bs=$iosize count=$loops &> /dev/null
[ $? -ne 0 ] && exit
sync
# Direct I/O overwriter
dd if=/dev/zero of=$testfile oflag=direct bs=$iosize count=$loops conv=notrunc &> /dev/null &
[ $? -ne 0 ] && exit
# Mmap writer
start=`expr $loops - 1`
for i in `seq $start -1 0`
do
offset=`expr $i \* $iosize`
$XFS_IO_PROG -F -f -c "mmap -w $offset $iosize" -c "mwrite $offset $iosize" $testfile
[ $? -ne 0 ] && exit
done
wait
echo "Silence is golden."
# success, all done
status=0
exit
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfstests 246: Test for race between direct I/O and mmap
2010-11-12 22:37 [PATCH] xfstests 246: Test for race between direct I/O and mmap Eric Sandeen
@ 2010-11-15 1:01 ` Lachlan McIlroy
2010-11-15 3:57 ` Eric Sandeen
2010-11-18 5:36 ` Dave Chinner
1 sibling, 1 reply; 4+ messages in thread
From: Lachlan McIlroy @ 2010-11-15 1:01 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs mailing list
----- "Eric Sandeen" <sandeen@redhat.com> wrote:
> From: Lachlan McIlroy <lmcilory@redhat.com>
lmcilroy - although I was briefly known as lmcilory due a HR error.
Eric, the test looks good to me, thanks for fixing the errors in it.
>
> A customer reported a problem:
>
> If a process is using mmap to write to a file on an
> ext4 filesystem while another process is using direct
> I/O to write to the same file the first thread may
> receive a SIGBUS during a page fault.
>
> A SIGBUS occurs if the page fault tries to access a
> page that is entirely beyond the end of the file but
> in this test case that should not be happening.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> #! /bin/bash
> # FS QA Test No. 246
> #
> # Test for race between direct I/O and mmap
> #
> #-----------------------------------------------------------------------
> # Copyright (c) 2010 Red Hat, Inc. All Rights Reserved.
> #
> # This program is free software; you can redistribute it and/or
> # modify it under the terms of the GNU General Public License as
> # published by the Free Software Foundation.
> #
> # This program is distributed in the hope that it would be useful,
> # but WITHOUT ANY WARRANTY; without even the implied warranty of
> # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> # GNU General Public License for more details.
> #
> # You should have received a copy of the GNU General Public License
> # along with this program; if not, write the Free Software
> Foundation,
> # Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
> #-----------------------------------------------------------------------
> #
> # creator
> owner=lmcilroy@redhat.com
>
> seq=`basename $0`
> echo "QA output created by $seq"
>
> here=`pwd`
> tmp=/tmp/$$
> status=1 # failure is the default!
> trap "_cleanup; exit \$status" 0 1 2 3 7 15
>
> _cleanup()
> {
> cd /
> rm -f $tmp.* $testfile
> wait
> }
>
> # get standard environment, filters and checks
> . ./common.rc
> . ./common.filter
>
> # real QA test starts here
>
> # Modify as appropriate.
> _supported_fs generic
> _supported_os Linux
>
> testfile=$TEST_DIR/$seq.$$
>
> loops=500
> iosize=1048576
>
> # Initialise file
> dd if=/dev/zero of=$testfile bs=$iosize count=$loops &> /dev/null
> [ $? -ne 0 ] && exit
> sync
>
> # Direct I/O overwriter
> dd if=/dev/zero of=$testfile oflag=direct bs=$iosize count=$loops
> conv=notrunc &> /dev/null &
> [ $? -ne 0 ] && exit
>
> # Mmap writer
> start=`expr $loops - 1`
> for i in `seq $start -1 0`
> do
> offset=`expr $i \* $iosize`
> $XFS_IO_PROG -F -f -c "mmap -w $offset $iosize" -c "mwrite $offset
> $iosize" $testfile
> [ $? -ne 0 ] && exit
> done
>
> wait
>
> echo "Silence is golden."
>
> # success, all done
> status=0
> exit
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfstests 246: Test for race between direct I/O and mmap
2010-11-12 22:37 [PATCH] xfstests 246: Test for race between direct I/O and mmap Eric Sandeen
2010-11-15 1:01 ` Lachlan McIlroy
@ 2010-11-18 5:36 ` Dave Chinner
1 sibling, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2010-11-18 5:36 UTC (permalink / raw)
To: Eric Sandeen; +Cc: Lachlan McIlroy, xfs mailing list
On Fri, Nov 12, 2010 at 04:37:07PM -0600, Eric Sandeen wrote:
>
>
> From: Lachlan McIlroy <lmcilory@redhat.com>
>
> A customer reported a problem:
>
> If a process is using mmap to write to a file on an
> ext4 filesystem while another process is using direct
> I/O to write to the same file the first thread may
> receive a SIGBUS during a page fault.
>
> A SIGBUS occurs if the page fault tries to access a
> page that is entirely beyond the end of the file but
> in this test case that should not be happening.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
looks fine to me.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-18 5:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-12 22:37 [PATCH] xfstests 246: Test for race between direct I/O and mmap Eric Sandeen
2010-11-15 1:01 ` Lachlan McIlroy
2010-11-15 3:57 ` Eric Sandeen
2010-11-18 5:36 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox