From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Samuel Kvasnica <samuel.kvasnica@ims.co.at>,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix exporting with left over 64-bit inodes
Date: Mon, 22 Nov 2010 05:23:51 -0500 [thread overview]
Message-ID: <20101122102350.GA7440@infradead.org> (raw)
In-Reply-To: <20101122003754.GE13830@dastard>
On Mon, Nov 22, 2010 at 11:37:54AM +1100, Dave Chinner wrote:
> Won't this mean that people exporting non-root directories suddenly
> have those exports stop working on a kernel upgrade due to changing
> the handle format?
No, if NFSD used ->encode_fh to encode the handle for the export
directory we wouldn't even have that problem. NFSD directly encodes
i_ino as 32-bit value for the legacy subdirectory export fs handle.
So it will break whenever that particulat inode has a too large
inode number.
Check fs/nfsd/nfsfh.h:mk_fsid() for the glory details.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-11-22 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 13:38 [PATCH] xfs: fix exporting with left over 64-bit inodes Christoph Hellwig
2010-11-20 8:29 ` Michael Monnerie
2010-11-21 10:57 ` Christoph Hellwig
2010-11-22 0:37 ` Dave Chinner
2010-11-22 9:05 ` Samuel Kvasnica
2010-11-22 10:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101122102350.GA7440@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=samuel.kvasnica@ims.co.at \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox