From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oANLBOuW008972 for ; Tue, 23 Nov 2010 15:11:24 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 1F9711C6BA58 for ; Tue, 23 Nov 2010 13:13:00 -0800 (PST) Received: from mail.internode.on.net (bld-mail19.adl2.internode.on.net [150.101.137.104]) by cuda.sgi.com with ESMTP id VLg6dJha2sTZc1Ni for ; Tue, 23 Nov 2010 13:13:00 -0800 (PST) Date: Wed, 24 Nov 2010 08:12:58 +1100 From: Dave Chinner Subject: Re: XFS reclaim lock order bug Message-ID: <20101123211258.GY22876@dastard> References: <20101123121802.GA4785@amd> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101123121802.GA4785@amd> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Nick Piggin Cc: xfs@oss.sgi.com On Tue, Nov 23, 2010 at 11:18:02PM +1100, Nick Piggin wrote: > Hi, > > IIRC I've reported this before. Perhaps it is a false positive, but even > so it is still annoying that it triggers and turns off lockdep for > subsequent debugging. > > Any chance it can get fixed or properly annotated? It is supposed to be handled by the re-initialisation of the ip->i_iolock in ->evict_inode (xfs_fs_evict_inode). An inode found in the reclaim state must have passed through this reinitialisation, so from a lockdep perspective the iolock in the vfs path is a different context to the iolock in the reclaim path. That fixed all the non-reclaim state related lockdep false positives, so Perhaps there is an issue with the lockdep reclaim state checking that does not interact well with re-initialised lock contexts? Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs