From: Christoph Hellwig <hch@infradead.org>
To: Bill Kendall <wkendall@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups
Date: Mon, 29 Nov 2010 09:56:27 -0500 [thread overview]
Message-ID: <20101129145627.GB22839@infradead.org> (raw)
In-Reply-To: <4CF3B875.3020701@sgi.com>
On Mon, Nov 29, 2010 at 08:28:05AM -0600, Bill Kendall wrote:
> There are several modules in xfsrestore which map files. None of them
> currently contain a destructor/cleanup function for unmapping the files.
> It would be a good change to make though.
If keeping it mapped later it's fine with me. So ACK from me for the
whole series.
Alex, maybe it's time to push out another xfsdump release after this?
There's quite a few changes that have accumulated.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-11-29 14:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 18:38 [PATCH v4 4/9] xfsrestore: mmap dirent names for faster lookups Bill Kendall
2010-11-23 13:48 ` Christoph Hellwig
2010-11-29 14:28 ` Bill Kendall
2010-11-29 14:56 ` Christoph Hellwig [this message]
2010-11-29 20:42 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101129145627.GB22839@infradead.org \
--to=hch@infradead.org \
--cc=wkendall@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox