From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	oAUMdGNR146300 for <xfs@oss.sgi.com>; Tue, 30 Nov 2010 16:39:16 -0600
Received: from bombadil.infradead.org (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP id AB7E41B7D4B
	for <xfs@oss.sgi.com>; Tue, 30 Nov 2010 14:40:59 -0800 (PST)
Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34])
	by cuda.sgi.com with ESMTP id 4Wm0CsolM8ladIGO for
	<xfs@oss.sgi.com>; Tue, 30 Nov 2010 14:40:59 -0800 (PST)
Date: Tue, 30 Nov 2010 17:40:57 -0500
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 3/8] xfs: bulk AIL insertion during transaction commit
Message-ID: <20101130224057.GA16143@infradead.org>
References: <1290993152-20999-1-git-send-email-david@fromorbit.com>
	<1290993152-20999-4-git-send-email-david@fromorbit.com>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1290993152-20999-4-git-send-email-david@fromorbit.com>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com

Generally looks good, a few minor comments below:

> +void
> +xfs_trans_committed_bulk(
> +	struct xfs_ail		*ailp,
> +	struct xfs_log_vec	*log_vector,
> +	xfs_lsn_t		commit_lsn,
> +	int			aborted)
> +{
> +#define LGIA_SIZE	32
> +	struct xfs_log_item	*lgia[LGIA_SIZE];

The lgia name seems a bit to obscure to me.  What about just log_items
as variable name, and LOG_ITEM_BATCH_SIZE or similar for the size?

> +			spin_lock(&ailp->xa_lock);
> +			xfs_trans_ail_update_bulk(ailp, lgia, LGIA_SIZE,
> +							commit_lsn);
> +			for (i = 0; i < LGIA_SIZE; i++)
> +				IOP_UNPIN(lgia[i], 0);

> +		spin_lock(&ailp->xa_lock);
> +		xfs_trans_ail_update_bulk(ailp, lgia, i, commit_lsn);
> +		for (j = 0; j < i; j++)
> +			IOP_UNPIN(lgia[j], 0);

It might be worth to factor these two little sniplets into a little
helper.

> + * Bulk update version of xfs_trans_ail_update.

That won't be a very useful comment anymore once xfs_trans_ail_update is
implemented as a wrapper around this function..

> +	struct xfs_log_item	**lgia,

Same naming comment here.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs