From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oB149OCe169402 for ; Tue, 30 Nov 2010 22:09:24 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id A35F31C8355E for ; Tue, 30 Nov 2010 20:11:04 -0800 (PST) Received: from mail.internode.on.net (bld-mail17.adl2.internode.on.net [150.101.137.102]) by cuda.sgi.com with ESMTP id Bh2N3lSoxQY6beje for ; Tue, 30 Nov 2010 20:11:04 -0800 (PST) Date: Wed, 1 Dec 2010 15:11:02 +1100 From: Dave Chinner Subject: Re: [PATCH 04/10] xfs: cleanup the xfs_iomap_write_* helpers Message-ID: <20101201041102.GE16922@dastard> References: <20101122130506.868076797@bombadil.infradead.org> <20101122130903.730638974@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101122130903.730638974@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Mon, Nov 22, 2010 at 08:05:10AM -0500, Christoph Hellwig wrote: > Remove passing the BMAPI_* flags to these helpers, in xfs_iomap_write_direct > the check BMAPI_DIRECT was always true, and in the xfs_iomap_write_delay > path is was never checked at all. Remove the nmap return value as > we never make use of it. > > Signed-off-by: Christoph Hellwig Makes sense - fewer useless parameters being passed around is good... Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs