From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 05/10] xfs: kill xfs_iomap
Date: Wed, 1 Dec 2010 15:32:27 +1100 [thread overview]
Message-ID: <20101201043227.GF16922@dastard> (raw)
In-Reply-To: <20101122130903.938808862@bombadil.infradead.org>
On Mon, Nov 22, 2010 at 08:05:11AM -0500, Christoph Hellwig wrote:
> Opencode the xfs_iomap code in it's two callers. The overlap of passed
> flags already was minimal and will be further reduced in the next patch.
>
> As a side effect the BMAPI_* flags for xfs_bmapi and the IO_* flags
> for I/O end processing are merged into a single set of flags, which
> should be a bit more descriptive of the operation we perform.
>
> Also improve the tracing by giving each caller it's own type set of
> tracepoints.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok. Minor comment:
> @@ -1472,7 +1563,7 @@ xfs_vm_direct_IO(
> ssize_t ret;
>
> if (rw & WRITE) {
> - iocb->private = xfs_alloc_ioend(inode, IO_NEW);
> + iocb->private = xfs_alloc_ioend(inode, 0);
>
> ret = __blockdev_direct_IO(rw, iocb, inode, bdev, iov,
> offset, nr_segs,
Using an ioend type to "0" is not very obvious given all the other
uses have a defined type. I know that this converted to IO_UNWRITTEN
in IO completion if neceessary, but perhaps a IO_DIRECT type might
be better just to document it? Or perhaps a comment stating why 0 is
OK to use here?
Everything else looks fine, so:
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-12-01 4:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-22 13:05 [PATCH 00/10] writeback updates Christoph Hellwig
2010-11-22 13:05 ` [PATCH 01/10] xfs: improve mapping type check in xfs_vm_writepage Christoph Hellwig
2010-12-01 4:01 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 02/10] xfs: remove some dead bio handling code Christoph Hellwig
2010-12-01 4:02 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 03/10] xfs: a few small tweaks for overwrites in xfs_vm_writepage Christoph Hellwig
2010-12-01 4:07 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 04/10] xfs: cleanup the xfs_iomap_write_* helpers Christoph Hellwig
2010-12-01 4:11 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 05/10] xfs: kill xfs_iomap Christoph Hellwig
2010-12-01 4:32 ` Dave Chinner [this message]
2010-11-22 13:05 ` [PATCH 06/10] xfs: simplify xfs_map_blocks Christoph Hellwig
2010-12-01 4:41 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 07/10] xfs: remove xfs_probe_cluster Christoph Hellwig
2010-12-01 4:43 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 08/10] xfs: remove the all_bh flag from xfs_convert_page Christoph Hellwig
2010-12-01 4:45 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 09/10] xfs: refactor xfs_vm_writepage Christoph Hellwig
2010-12-01 4:49 ` Dave Chinner
2010-11-22 13:05 ` [PATCH 10/10] xfs: simplify xfs_map_at_offset Christoph Hellwig
2010-12-01 4:50 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 8:42 [PATCH 00/10] writeback updates V2 Christoph Hellwig
2010-12-10 8:42 ` [PATCH 05/10] xfs: kill xfs_iomap Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101201043227.GF16922@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox