Re: [PATCH 10/10] xfs: simplify xfs_map_at_offset

Dave Chinner
2010-12-01T04:48:28Z

On Mon, Nov 22, 2010 at 08:05:16AM -0500, Christoph Hellwig wrote:
> Move the buffer locking into the callers as they need to do it wether they
> call xfs_map_at_offset or not. Remove the b_bdev assignment, which is
> already done by get_blocks. Remove the duplicate extent type asserts in
> xfs_convert_page just before calling xfs_map_at_offset.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com