From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15])
	by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id
	oB14lYR4172840 for <xfs@oss.sgi.com>; Tue, 30 Nov 2010 22:47:34 -0600
Received: from mail.internode.on.net (localhost [127.0.0.1])
	by cuda.sgi.com (Spam Firewall) with ESMTP id 8BE631C84F46
	for <xfs@oss.sgi.com>; Tue, 30 Nov 2010 20:49:16 -0800 (PST)
Received: from mail.internode.on.net (bld-mail14.adl6.internode.on.net
	[150.101.137.99]) by cuda.sgi.com with ESMTP id
	v1SyIZvZ6FsvcbCM for <xfs@oss.sgi.com>;
	Tue, 30 Nov 2010 20:49:16 -0800 (PST)
Date: Wed, 1 Dec 2010 15:49:13 +1100
From: Dave Chinner <david@fromorbit.com>
Subject: Re: [PATCH 09/10] xfs: refactor xfs_vm_writepage
Message-ID: <20101201044913.GJ16922@dastard>
References: <20101122130506.868076797@bombadil.infradead.org>
	<20101122130904.770817106@bombadil.infradead.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <20101122130904.770817106@bombadil.infradead.org>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: xfs-bounces@oss.sgi.com
Errors-To: xfs-bounces@oss.sgi.com
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com

On Mon, Nov 22, 2010 at 08:05:15AM -0500, Christoph Hellwig wrote:
> After the last patches the code for overwrites is the same as for
> delayed and unwritten extents except that it doesn't need to call
> xfs_map_at_offset.  Take care of that fact to simplify xfs_vm_writepage.
> 
> The buffer loop now first checks the type of buffer and checks/sets
> the ioend type, or continues to the next buffer if it's not interesting
> to us.  Only after that we validate the iomap and perform the block
> mapping if needed, all in common code for the cases where we have to
> do work.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Much neater and easier to understand.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs