Re: [PATCH 09/10] xfs: refactor xfs_vm_writepage

Dave Chinner
2010-12-01T04:47:34Z

On Mon, Nov 22, 2010 at 08:05:15AM -0500, Christoph Hellwig wrote:
> After the last patches the code for overwrites is the same as for
> delayed and unwritten extents except that it doesn't need to call
> xfs_map_at_offset. Take care of that fact to simplify xfs_vm_writepage.
>
> The buffer loop now first checks the type of buffer and checks/sets
> the ioend type, or continues to the next buffer if it's not interesting
> to us. Only after that we validate the iomap and perform the block
> mapping if needed, all in common code for the cases where we have to
> do work.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Much neater and easier to understand.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com