From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oB14mRns172900 for ; Tue, 30 Nov 2010 22:48:28 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C379E1402E58 for ; Tue, 30 Nov 2010 20:50:09 -0800 (PST) Received: from mail.internode.on.net (bld-mail17.adl2.internode.on.net [150.101.137.102]) by cuda.sgi.com with ESMTP id ssBSDhyyyjGzoX27 for ; Tue, 30 Nov 2010 20:50:09 -0800 (PST) Date: Wed, 1 Dec 2010 15:50:06 +1100 From: Dave Chinner Subject: Re: [PATCH 10/10] xfs: simplify xfs_map_at_offset Message-ID: <20101201045006.GK16922@dastard> References: <20101122130506.868076797@bombadil.infradead.org> <20101122130904.961028436@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101122130904.961028436@bombadil.infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Mon, Nov 22, 2010 at 08:05:16AM -0500, Christoph Hellwig wrote: > Move the buffer locking into the callers as they need to do it wether they > call xfs_map_at_offset or not. Remove the b_bdev assignment, which is > already done by get_blocks. Remove the duplicate extent type asserts in > xfs_convert_page just before calling xfs_map_at_offset. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs