Re: [PATCH 02/14] xfs: clean up log space grant functions

Christoph Hellwig
2010-12-02T11:39:06Z

On Thu, Dec 02, 2010 at 12:48:33PM +1100, Dave Chinner wrote:
> Ok, so your main objection is the needless addition to the queue?
> That can be avoided easily enough via a local variable. Would that
> be sufficient to alleviate your concerns?

The main objection is that the new code might be a bit shorted,
but is a lot less readable. If you really want it go with it and
an updated changelog mentioning the behaviour change, but I don't
really feel too good about it.