Re: [PATCH 5/8] xfs: consume iodone callback items on buffers as they are processed

Christoph Hellwig
2010-11-30T20:22:18Z

On Mon, Nov 29, 2010 at 12:12:29PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> To allow buffer iodone callbacks to consume multiple items off the
> callback list, first we need to convert the xfs_buf_do_callbacks()
> to consume items and always pull the next item from the head of the
> list.
>
> The means the item list walk is never dependent on knowing the
> next item on the list and hence allows callbacks to remove itesm
> from the list as well. This allows callbacks to do bulk operations
> by scanning the list for identical callbacks, consuming them all
> and then processing them in bulk, negating the need for multiple
> callbacks of that type.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>