Re: [PATCH 8/8] xfs: use AIL bulk delete function to implement single delete

Christoph Hellwig
2010-12-06T14:35:45Z

> -/*
> * Bulk update version of xfs_trans_ail_delete
> *
> * This version takes an array of log items that all need to removed from the
> * AIL. The caller is already holding the AIL lock, and done all the checks

Not overly useful now that the non-bulk version is gone.

> * necessary to ensure the items passed in via @lgia are ready for deletion.
> + * If an item we delete in the AIL is the minimum one, update the tail lsn in
> + * the log manager.
> *
> * This function will not drop the AIL lock until all items are removed from
> * the AIL to minimise the amount of lock traffic on the AIL. This does not
> * greatly increase the AIL hold time, but does significantly reduce the amount
> * of traffic on the lock, especially during IO completion.
> + *
> + * This function must be called with the AIL lock held. The lock is dropped
> + * before returning.

These should be in the patch introducing xfs_trans_ail_delete_bulk.

Otherwise looks good.