Re: [PATCH 2/8] xfs: clean up xfs_ail_delete()

Christoph Hellwig
2010-11-30T20:17:32Z

On Mon, Nov 29, 2010 at 12:12:26PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> xfs_ail_delete() has a needlessly complex interface. It returns the log item
> that was passed in for deletion (which the callers then assert is identical to
> the one passed in), and callers of xfs_ail_delete() still need to invalidate
> current traversal cursors.
>
> Make xfs_ail_delete() return void, move the cursor invalidation inside it, and
> clean up the callers just to use the log item pointer they passed in.
>
> While cleaning up, remove the messy and unnecessary "/* ARGUSED */" comments
> around all these functions.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>