From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oB222utm245616 for ; Wed, 1 Dec 2010 20:02:57 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id B138E1C851FC for ; Wed, 1 Dec 2010 18:04:39 -0800 (PST) Received: from mail.internode.on.net (bld-mail13.adl6.internode.on.net [150.101.137.98]) by cuda.sgi.com with ESMTP id 25HjJPQGDmzktmBs for ; Wed, 01 Dec 2010 18:04:39 -0800 (PST) Date: Thu, 2 Dec 2010 13:04:09 +1100 From: Dave Chinner Subject: Re: [PATCH 05/14] xfs: make AIL tail pushing independent of the grant lock Message-ID: <20101202020409.GR16922@dastard> References: <1290994712-21376-1-git-send-email-david@fromorbit.com> <1290994712-21376-6-git-send-email-david@fromorbit.com> <20101201124540.GC612@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20101201124540.GC612@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Wed, Dec 01, 2010 at 07:45:40AM -0500, Christoph Hellwig wrote: > Once l_tail_lsn and l_last_sync_lsn are converted to atomic64_ts later > in the series passing them in separately becomes pointless again. Maybe > scale the patch back a bit and require the caller to hold l_grant_lock > for now, until the atomic64_t conversion happens. Same reasoning as for the change to xlog_space_left - the values should only be sampled once for correctness, which is why I pass them into the function. more "const" annotations, I guess. Cheers, Dave. -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs