From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: XFS Mailing List <xfs@oss.sgi.com>, dchinner@redhat.com
Subject: Re: xfstests 065 failures
Date: Thu, 2 Dec 2010 13:21:16 +1100 [thread overview]
Message-ID: <20101202022116.GW16922@dastard> (raw)
In-Reply-To: <1291235379.2556.28.camel@doink>
On Wed, Dec 01, 2010 at 02:29:39PM -0600, Alex Elder wrote:
> Dave, you were asking on IRC about test 065 failures.
> I asked Bill Kendall about it and he bisected to find
> that the commit below seems to be where the problems
> started. I believe the problem is that one of the
> times is not updated properly when renaming the file
> "addedfile4". Here are the commands that might affect
> that file in test 065:
>
> mv addeddir4/addedfile5 addeddir4/addedfile4
> mv addeddir4 addeddir6
>
> I glanced at the commit and saw nothing obviously
> wrong, but at the moment I can't really dig into
> it any deeper so I thought I'd report what Bill
> found so others could look.
Yeah, I know that this patch was the cause, and IIRC it only affects
a hard linked directory. What I found is that the iterative dump
actually contains all the correct changes (the restore part of the
test does not fail) - it's just that the dump image table of
contents does not contain the all the changes. I haven't tracked
down why the dump TOC does not contain a modification that is
actually in the dump yet....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-12-02 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-01 20:29 xfstests 065 failures Alex Elder
2010-12-02 2:21 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101202022116.GW16922@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=dchinner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox