Re: [PATCH 01/14] xfs: convert log grant ticket queues to list heads

Christoph Hellwig
2010-11-30T22:57:18Z

On Mon, Nov 29, 2010 at 12:38:19PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The grant write and reserve queues use a roll-your-own double linked
> list, so convert it to a standard list_head structure and convert
> all the list traversals to use list_for_each_entry(). We can also
> get rid of the XLOG_TIC_IN_Q flag as we can use the list_empty()
> check to tell if the ticket is in a list or not.

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

A minor comment below:

> - __field(void *, reserve_headq)
> - __field(void *, write_headq)
> + __field(void *, reserveq)
> + __field(void *, writeq)

Not sure why added these to the traces originally, but imho
it's pretty pointless. If we care at all we could log a boolean
flag if the queues are empty or not.