From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups
Date: Thu, 16 Dec 2010 10:38:47 -0500 [thread overview]
Message-ID: <20101216153846.GC24185@infradead.org> (raw)
In-Reply-To: <1292214743-18073-6-git-send-email-david@fromorbit.com>
On Mon, Dec 13, 2010 at 03:32:19PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> The xfaild often tries to rest to wait for congestion to pass of for
> IO to complete, but is regularly woken in tail-pushing situations.
> In severe cases, the xfsaild is getting woken tens of thousands of
> times a second. Reduce the number needless wakeups by only waking
> the xfsaild if the new target is larger than the old one. Further
> make short sleeps uninterruptible as they occur when the xfsaild has
> decided it needs to back off to allow some IO to complete and being
> woken early is counter-productive.
This patch causes softlockup warnings in xfsaild for various testcases
on my 32-bit x86 VM, but the testcases continue otherwise normally.
Example below:
[ 361.692515] INFO: task xfsaild/vdb5:8705 blocked for more than 120 seconds.
[ 361.697272] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[ 361.703929] xfsaild/vdb5 D 00000000 0 8705 2 0x00000000
[ 361.708148] f4933f10 00000046 f4b37464 00000000 00000000 f4b37100 f4b37100 00000046
[ 361.711501] f4933eb4 00000046 f4b37100 c0936092 f4b37264 f4b37268 00000000 c0d52d00
[ 361.714786] c0d52d08 c0e96c00 f5735d38 f4933ec0 f4b37100 f6946c00 f4933eec c0160553
[ 361.718120] Call Trace:
[ 361.721856] [<c0936092>] ? _raw_spin_unlock_irq+0x22/0x30
[ 361.723439] [<c0160553>] ? finish_task_switch+0x73/0x100
[ 361.725056] [<c0160517>] ? finish_task_switch+0x37/0x100
[ 361.726592] [<c09334b3>] ? schedule+0x263/0x9d0
[ 361.727932] [<c0198f4b>] ? trace_hardirqs_off+0xb/0x10
[ 361.729548] [<c0933f05>] schedule_timeout+0x185/0x250
[ 361.731258] [<c09360d5>] ? _raw_spin_unlock_irqrestore+0x35/0x60
[ 361.733037] [<c019c68b>] ? trace_hardirqs_on+0xb/0x10
[ 361.734513] [<c04ed504>] xfsaild+0x54/0xc0
[ 361.735786] [<c04ed4b0>] ? xfsaild+0x0/0xc0
[ 361.737171] [<c0187634>] kthread+0x74/0x80
[ 361.738446] [<c01875c0>] ? kthread+0x0/0x80
[ 361.739987] [<c013507a>] kernel_thread_helper+0x6/0x1c
[ 361.741589] no locks held by xfsaild/vdb5/8705.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-12-16 15:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 4:32 xfs: AIL lock contention reduction V3 Dave Chinner
2010-12-13 4:32 ` [PATCH 1/9] xfs: fix EFI transaction cancellation Dave Chinner
2010-12-17 11:18 ` Christoph Hellwig
2010-12-13 4:32 ` [PATCH 2/9] xfs: Pull EFI/EFD handling out from under the AIL lock Dave Chinner
2010-12-17 11:22 ` Christoph Hellwig
2010-12-20 1:00 ` Dave Chinner
2010-12-13 4:32 ` [PATCH 3/9] xfs: clean up xfs_ail_delete() Dave Chinner
2010-12-13 4:32 ` [PATCH 4/9] xfs: bulk AIL insertion during transaction commit Dave Chinner
2010-12-17 11:25 ` Christoph Hellwig
2010-12-13 4:32 ` [PATCH 5/9] xfs: reduce the number of AIL push wakeups Dave Chinner
2010-12-16 15:38 ` Christoph Hellwig [this message]
2010-12-16 21:50 ` Dave Chinner
2010-12-17 0:23 ` Christoph Hellwig
2010-12-13 4:32 ` [PATCH 6/9] xfs: consume iodone callback items on buffers as they are processed Dave Chinner
2010-12-13 4:32 ` [PATCH 7/9] xfs: remove all the inodes on a buffer from the AIL in bulk Dave Chinner
2010-12-17 11:25 ` Christoph Hellwig
2010-12-13 4:32 ` [PATCH 9/9] xfs: use AIL bulk delete function to implement single delete Dave Chinner
2010-12-17 14:16 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216153846.GC24185@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox