From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id oBGFasdU077829 for ; Thu, 16 Dec 2010 09:36:54 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 4DF4F152F06B for ; Thu, 16 Dec 2010 07:38:47 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id vaVlam5tVUIJmFZZ for ; Thu, 16 Dec 2010 07:38:47 -0800 (PST) Date: Thu, 16 Dec 2010 10:38:47 -0500 From: Christoph Hellwig Subject: Re: [PATCH 5/9] xfs: reduce the number of AIL push wakeups Message-ID: <20101216153846.GC24185@infradead.org> References: <1292214743-18073-1-git-send-email-david@fromorbit.com> <1292214743-18073-6-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1292214743-18073-6-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Mon, Dec 13, 2010 at 03:32:19PM +1100, Dave Chinner wrote: > From: Dave Chinner > > The xfaild often tries to rest to wait for congestion to pass of for > IO to complete, but is regularly woken in tail-pushing situations. > In severe cases, the xfsaild is getting woken tens of thousands of > times a second. Reduce the number needless wakeups by only waking > the xfsaild if the new target is larger than the old one. Further > make short sleeps uninterruptible as they occur when the xfsaild has > decided it needs to back off to allow some IO to complete and being > woken early is counter-productive. This patch causes softlockup warnings in xfsaild for various testcases on my 32-bit x86 VM, but the testcases continue otherwise normally. Example below: [ 361.692515] INFO: task xfsaild/vdb5:8705 blocked for more than 120 seconds. [ 361.697272] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 361.703929] xfsaild/vdb5 D 00000000 0 8705 2 0x00000000 [ 361.708148] f4933f10 00000046 f4b37464 00000000 00000000 f4b37100 f4b37100 00000046 [ 361.711501] f4933eb4 00000046 f4b37100 c0936092 f4b37264 f4b37268 00000000 c0d52d00 [ 361.714786] c0d52d08 c0e96c00 f5735d38 f4933ec0 f4b37100 f6946c00 f4933eec c0160553 [ 361.718120] Call Trace: [ 361.721856] [] ? _raw_spin_unlock_irq+0x22/0x30 [ 361.723439] [] ? finish_task_switch+0x73/0x100 [ 361.725056] [] ? finish_task_switch+0x37/0x100 [ 361.726592] [] ? schedule+0x263/0x9d0 [ 361.727932] [] ? trace_hardirqs_off+0xb/0x10 [ 361.729548] [] schedule_timeout+0x185/0x250 [ 361.731258] [] ? _raw_spin_unlock_irqrestore+0x35/0x60 [ 361.733037] [] ? trace_hardirqs_on+0xb/0x10 [ 361.734513] [] xfsaild+0x54/0xc0 [ 361.735786] [] ? xfsaild+0x0/0xc0 [ 361.737171] [] kthread+0x74/0x80 [ 361.738446] [] ? kthread+0x0/0x80 [ 361.739987] [] kernel_thread_helper+0x6/0x1c [ 361.741589] no locks held by xfsaild/vdb5/8705. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs