From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Nick Piggin <npiggin@gmail.com>, xfs@oss.sgi.com
Subject: Re: xfs_efi_item slab leak
Date: Tue, 21 Dec 2010 11:54:05 +1100 [thread overview]
Message-ID: <20101221005405.GN5193@dastard> (raw)
In-Reply-To: <20101220113139.GA10324@infradead.org>
On Mon, Dec 20, 2010 at 06:31:39AM -0500, Christoph Hellwig wrote:
> On Sat, Dec 18, 2010 at 11:02:45AM +1100, Dave Chinner wrote:
> > Ok, after unmounting everything I can see two items in remaining in
> > the xfs_efi_item cache after an xfstests run. ??t's probably to do
> > with a filesystem shutdown not cleaning them up correctly. I'll put
> > it on my list of stuff to track down.
>
> Does it still happen with your working tree? The incorrect handling
> of IOP_UNPING with remove == 1 looks like it could cause something
> similar.
I haven't checked the current patch set - just on the kernel that I
was currently running - I'll do more analysis later this afternoon.
I agree that the IOP_UNPIN() handling is a likely culprit, though.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-12-21 0:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 18:04 xfs_efi_item slab leak Nick Piggin
2010-12-18 0:02 ` Dave Chinner
2010-12-20 11:31 ` Christoph Hellwig
2010-12-21 0:54 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221005405.GN5193@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=npiggin@gmail.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox