From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfsqa: make hole tests independent of speculative allocation patterns
Date: Tue, 21 Dec 2010 11:46:32 -0500 [thread overview]
Message-ID: <20101221164632.GB9093@infradead.org> (raw)
In-Reply-To: <1292922120-28360-1-git-send-email-david@fromorbit.com>
On Tue, Dec 21, 2010 at 08:02:00PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Many of the "count-the-holes" tests (008, 012, etc) do writes that extend the
> file and hence allocation patterns are dependent on speculative allocation
> beyond EOF behaviour. Hence if we change that behaviour, these tests all fail
> because there is a different pattern of holes.
>
> Make the tests independent of EOF preallocation behaviour by first truncating
> the file to the size the test is defined to use. This prevents speculative
> prealocation from occurring, and hence changes in such behaviour will not cause
> the tests to fail.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good and fixes the test failure I saw with the dirty release
counter patch.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-12-21 16:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 9:02 [PATCH] xfsqa: make hole tests independent of speculative allocation patterns Dave Chinner
2010-12-21 16:46 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101221164632.GB9093@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox