From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] repair: warn if running in low memory mode
Date: Tue, 4 Jan 2011 04:52:56 -0500 [thread overview]
Message-ID: <20110104095256.GA26885@infradead.org> (raw)
In-Reply-To: <1294121563-17150-1-git-send-email-david@fromorbit.com>
On Tue, Jan 04, 2011 at 05:12:43PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> When checking large filesystems, xfs_repair makes an estimate of how
> much RAM it will need to execute effectively. If the amount of RAM
> is less than this, it reduces the bhash size and turns of
> prefetching, which will substantially slow down the repair process.
> Add a warning that indicates this is happening, along with a
> recommendation of how much RAM repair calculates it needs to run
> with prefetching enabled.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> + do_warn(_("Not enough RAM available for repair "
> + "to enable prefetching. This will be "
> + "_slow_.\n"
> + "You need at least %luMB RAM to run "
> + "with prefetching enabled."),
> + mem_used * 1280 / (1024 * 1024));
Maybe but the strings on a separate line to be easier readable and
greppable, e.g.:
do_warn(
_("Not enough RAM available for repair to enable prefetching. "
"This will be _slow_.\n"
"You need at least %luMB RAM to run with prefetching enabled."),
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-04 9:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 6:12 [PATCH] repair: warn if running in low memory mode Dave Chinner
2011-01-04 9:52 ` Christoph Hellwig [this message]
2011-01-05 22:25 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104095256.GA26885@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox