From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: add FITRIM support
Date: Thu, 6 Jan 2011 13:03:05 -0500 [thread overview]
Message-ID: <20110106180305.GA32670@infradead.org> (raw)
In-Reply-To: <1294178115.2485.19.camel@doink>
> > + * Copyright (C) 2010 Red Hat, Inc.
>
> Maybe 2011 now...
Nothing major changes in 2011, so no.
> > + * If the extent is entirely outside of the range we are
> > + * supposed to discard skip it. Do not bother to trim
> > + * down partially overlapping ranges for now.
> > + */
> > + if (XFS_AGB_TO_FSB(mp, agno, fbno) + flen < start ||
> > + XFS_AGB_TO_FSB(mp, agno, fbno) > start + len) {
>
> ^
> I think this should be >=
Yes.
> Do you want to add a boilerplate copyright header here?
Kinda hard to claim copyright on a single prototype.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2011-01-06 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-02 7:22 [PATCH] xfs: add FITRIM support Christoph Hellwig
2011-01-04 0:15 ` Dave Chinner
2011-01-04 21:55 ` Alex Elder
2011-01-06 18:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110106180305.GA32670@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox