public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Michael Monnerie <michael.monnerie@is.it-management.at>,
	Lukas Czerner <lczerner@redhat.com>,
	Christoph Hellwig <hch@infradead.org>,
	xfs@oss.sgi.com
Subject: Re: xfs: add FITRIM support
Date: Thu, 6 Jan 2011 13:08:18 -0500	[thread overview]
Message-ID: <20110106180818.GC32670@infradead.org> (raw)
In-Reply-To: <20110105225039.GD8322@dastard>

On Thu, Jan 06, 2011 at 09:50:39AM +1100, Dave Chinner wrote:
> If we want optimised, only-trim-what-we-free behaviour, we need to
> hook into the transaction subsystem and issue TRIM commands at the
> time extents are actually freed. That is much more complex to
> implement but much easier to optimise because it doesn't require
> persistent state on disk. However, most devices are simply not ready
> to handle the flood of TRIM commands this generates, with
> performance degrading by ~10-20% for the best of devices and
> _10-100x_ for the worst...

I tested a few devices that have zero to 1% degradation, but those
were arrays, which allow for queued WRITE SAME/UNMAP commands instead
of the unqueued TRIM in ATA.  But I'm gettig close to finishing the
online discard and will start another benchmark session soon.  With
PCI-E flash devices that aren't limited by the ATA protocol, and the
proposed queueable TRIM command this looks like what we need for the
future.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2011-01-06 18:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-25 11:23 xfs: add FITRIM support Christoph Hellwig
2010-12-22 21:41 ` Alex Elder
2010-12-28 16:09   ` Christoph Hellwig
2011-01-03 10:49     ` Lukas Czerner
2010-12-23  1:44 ` Dave Chinner
2010-12-30 11:41   ` Christoph Hellwig
2011-01-03 10:57     ` Lukas Czerner
2011-01-03 23:25       ` Dave Chinner
2011-01-05 10:21         ` Lukas Czerner
2011-01-05 22:07           ` Michael Monnerie
2011-01-05 22:50             ` Dave Chinner
2011-01-06  8:10               ` Michael Monnerie
2011-01-06  8:33                 ` Lukas Czerner
2011-01-06  8:40                   ` Lukas Czerner
2011-01-06  9:17                 ` Dave Chinner
2011-01-06 16:50                   ` Michael Monnerie
2011-01-06 18:10                     ` Christoph Hellwig
2011-01-06 18:08               ` Christoph Hellwig [this message]
2011-01-06 18:06             ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110106180818.GC32670@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=lczerner@redhat.com \
    --cc=michael.monnerie@is.it-management.at \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox