From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write
Date: Fri, 7 Jan 2011 03:58:30 -0500 [thread overview]
Message-ID: <20110107085830.GC10829@infradead.org> (raw)
In-Reply-To: <1294116518-14908-6-git-send-email-david@fromorbit.com>
> +This also clearly indicates that XFS
> + * does not fall back to buffered IO in the direct IO write path.
I don't think this comment belongs into the function header. It's
already present in the right place anyway, so it can just be removed.
> + xfs_buftarg_t *target = XFS_IS_REALTIME_INODE(ip) ?
> + mp->m_rtdev_targp : mp->m_ddev_targp;
struct xfs_buftarg, please.
> + trace_xfs_file_direct_write(ip, count, iocb->ki_pos, 0);
> + ret = generic_file_direct_write(iocb, iovp,
> + &nr_segs, pos, &iocb->ki_pos, count, ocount);
> +
> + /* No fallback to buffered IO on errors for XFS. */
> + return ret;
I'd add an
ASSERT(ret < 0 || ret == count);
here to make sure we don't get problems due to changes in the core
direct I/O code.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-07 8:56 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 4:48 [PATCH 0/8] xfs: prevent corruption due to overlapping AIO DIO V2 Dave Chinner
2011-01-04 4:48 ` [PATCH 1/8] xfs: ensure sync write errors are returned Dave Chinner
2011-01-05 1:53 ` Alex Elder
2011-01-07 8:45 ` Christoph Hellwig
2011-01-07 9:07 ` Dave Chinner
2011-01-04 4:48 ` [PATCH 2/8] xfs: factor common post-write isize handling code Dave Chinner
2011-01-05 1:54 ` Alex Elder
2011-01-04 4:48 ` [PATCH 4/8] xfs: introduce xfs_rw_lock() helpers for locking the inode Dave Chinner
2011-01-05 1:54 ` Alex Elder
2011-01-05 7:55 ` Dave Chinner
2011-01-04 4:48 ` [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write Dave Chinner
2011-01-05 1:54 ` Alex Elder
2011-01-05 7:36 ` Dave Chinner
2011-01-07 8:58 ` Christoph Hellwig [this message]
2011-01-07 9:21 ` Dave Chinner
2011-01-04 4:48 ` [PATCH 6/8] xfs: split buffered " Dave Chinner
2011-01-05 1:55 ` Alex Elder
2011-01-04 4:48 ` [PATCH 7/8] xfs: factor common write setup code Dave Chinner
2011-01-05 1:55 ` Alex Elder
2011-01-07 8:53 ` Christoph Hellwig
2011-01-07 9:20 ` Dave Chinner
2011-01-04 4:48 ` [PATCH 8/8] xfs: serialise unaligned direct IOs Dave Chinner
2011-01-05 1:55 ` Alex Elder
2011-01-05 1:53 ` [PATCH 0/8] xfs: prevent corruption due to overlapping AIO DIO V2 Alex Elder
-- strict thread matches above, loose matches on Subject: below --
2011-01-07 11:30 [PATCH 0/8] xfs: prevent corruption due to overlapping AIO DIO V3 Dave Chinner
2011-01-07 11:30 ` [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write Dave Chinner
2011-01-10 19:24 ` Christoph Hellwig
2011-01-10 23:37 [PATCH 0/8] xfs: prevent corruption due to overlapping AIO DIO V4 Dave Chinner
2011-01-10 23:37 ` [PATCH 5/8] xfs: split direct IO write path from xfs_file_aio_write Dave Chinner
2011-01-11 21:44 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110107085830.GC10829@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox