* xfs: Add log level to assertion printk
@ 2011-01-07 3:30 Anton Blanchard
2011-01-07 12:55 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Anton Blanchard @ 2011-01-07 3:30 UTC (permalink / raw)
To: Alex Elder, Dave Chinner, Christoph Hellwig; +Cc: xfs-masters, xfs
I received a ppc64 bug report involving xfs but the assertion was filtered out
by the console log level. Use KERN_CRIT to ensure it makes it out.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
diff --git a/fs/xfs/support/debug.c b/fs/xfs/support/debug.c
index 975aa10..86162e5 100644
--- a/fs/xfs/support/debug.c
+++ b/fs/xfs/support/debug.c
@@ -104,7 +104,8 @@ xfs_fs_vcmn_err(
void
assfail(char *expr, char *file, int line)
{
- printk("Assertion failed: %s, file: %s, line: %d\n", expr, file, line);
+ printk(KERN_CRIT "Assertion failed: %s, file: %s, line: %d\n", expr,
+ file, line);
BUG();
}
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: xfs: Add log level to assertion printk
2011-01-07 3:30 xfs: Add log level to assertion printk Anton Blanchard
@ 2011-01-07 12:55 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2011-01-07 12:55 UTC (permalink / raw)
To: Anton Blanchard
Cc: xfs-masters, xfs, Dave Chinner, Christoph Hellwig, Alex Elder
On Fri, Jan 07, 2011 at 02:30:41PM +1100, Anton Blanchard wrote:
>
> I received a ppc64 bug report involving xfs but the assertion was filtered out
> by the console log level. Use KERN_CRIT to ensure it makes it out.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-07 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-07 3:30 xfs: Add log level to assertion printk Anton Blanchard
2011-01-07 12:55 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox