public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Monnerie <michael.monnerie@is.it-management.at>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_repair: multithread phase 2
Date: Mon, 10 Jan 2011 14:25:47 +0100	[thread overview]
Message-ID: <201101101425.48134@zmi.at> (raw)
In-Reply-To: <20110110084122.GF28803@dastard>


[-- Attachment #1.1: Type: Text/Plain, Size: 1293 bytes --]

On Montag, 10. Januar 2011 Dave Chinner wrote:
> Pretty much
> every sata disk supports NCQ these days, and default to a depth of
> 32, which means we can have 32 concurrent reads in progress at once.
> Phase 2 is all synchronous IO, so the only way to hide the IO
> latency is to queue work to multiple threads and switch between the
> threadsto work on another queue when the current one blocks waiting
> for IO.

This is interesting. Did you measure this with a rotating single disk? 
Is the idle time between two synchronous reads bigger than the time 
needed to move the disk head to another cylinder and read a sector? That 
takes ~15ms on a normal disk, incredibly long compared to cpu speed. 
Even with NCQ, the disk would have to swing the head a lot, and just 
from thinking about it I wouldn't believe that it's faster like this.

But I'm sure you tested it so I take it as given that it's like that. 
Cool improvement, btw :-)

-- 
mit freundlichen Grüssen,
Michael Monnerie, Ing. BSc

it-management Internet Services: Protéger
http://proteger.at [gesprochen: Prot-e-schee]
Tel: +43 660 / 415 6531

// ****** Radiointerview zum Thema Spam ******
// http://www.it-podcast.at/archiv.html#podcast-100716
// 
// Haus zu verkaufen: http://zmi.at/langegg/

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 121 bytes --]

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-01-10 13:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-10  0:44 [PATCH] xfs_repair: multithread phase 2 Dave Chinner
2011-01-10  7:57 ` Michael Monnerie
2011-01-10  8:41   ` Dave Chinner
2011-01-10 13:25     ` Michael Monnerie [this message]
2011-01-10 19:18       ` Christoph Hellwig
2011-01-10 19:17     ` Christoph Hellwig
2011-01-10 21:53       ` Matthias Schniedermeyer
2011-01-10 18:55 ` Christoph Hellwig
2011-02-01 23:39 ` Alex Elder
  -- strict thread matches above, loose matches on Subject: below --
2011-01-04  6:13 Dave Chinner
2011-01-04 10:02 ` Christoph Hellwig
2011-01-04 12:00   ` Dave Chinner
2011-01-05 23:42 ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101101425.48134@zmi.at \
    --to=michael.monnerie@is.it-management.at \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox