From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 02/12] xfsprogs: simplify leading '/' handling in generate_obfuscated_name()
Date: Mon, 10 Jan 2011 15:13:35 -0500 [thread overview]
Message-ID: <20110110201335.GB27277@infradead.org> (raw)
In-Reply-To: <1293741612.2294.354.camel@doink>
On Thu, Dec 30, 2010 at 02:40:12PM -0600, Alex Elder wrote:
> In generate_obfuscated_name(), the incoming file name is allowed to
> start with a '/' character, in which case it is copied over to the
> new file name and ignored for the remainder of the hash calculation.
> Simplify the affected code by processing the '/' right away, and
> using a pointer thereafter for the start of the new file name.
The actual change looks good to me, but why would we ever have a /
in the filename, and if we do why would we treat it special?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-10 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 20:40 [PATCH 02/12] xfsprogs: simplify leading '/' handling in generate_obfuscated_name() Alex Elder
2011-01-10 20:13 ` Christoph Hellwig [this message]
2011-01-10 20:23 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110201335.GB27277@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox