From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add simple splice test
Date: Tue, 11 Jan 2011 12:38:45 -0500 [thread overview]
Message-ID: <20110111173845.GC24025@infradead.org> (raw)
In-Reply-To: <1294702344-15035-1-git-send-email-david@fromorbit.com>
> +echo "Feel the serenity."
> +
> +SRC=$TEST_DIR/$seq.src
> +DST=$TEST_DIR/$seq.dst
> +
> +$XFS_IO_PROG -f -c "pwrite -S 0xa5a55a5a 0 32768k" -c fsync $SRC > /dev/null 2>&1
> +$XFS_IO_PROG -f -c "sendfile -i $SRC 0 32768k" -c fsync $DST > /dev/null 2>&1
> +
> +diff $SRC $DST
I think this should removfe the two files to make sure the test is
reproducible and doesn't overwrite an existing file during the second
run. Also I'd recomment not to redirect the output to /dev/null but use
our normal xfs_io filters and make the output part of the golden output.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-11 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 23:32 [PATCH] xfstests: add simple splice test Dave Chinner
2011-01-11 17:38 ` Christoph Hellwig [this message]
2011-01-11 20:50 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111173845.GC24025@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox