From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code
Date: Mon, 24 Jan 2011 03:47:32 -0500 [thread overview]
Message-ID: <20110124084732.GA4378@infradead.org> (raw)
In-Reply-To: <1294649091-27174-3-git-send-email-david@fromorbit.com>
> +typedef int32_t atomic_t;
> +typedef int64_t atomic64_t;
> +
> +#define atomic_inc_return(x) (++(*(x)))
> +#define atomic_dec_return(x) (--(*(x)))
> +
> +#define atomic64_read(x) *(x)
> +#define atomic64_set(x, v) (*(x) = v)
These defintions are pretty dangerous if we ever happens to use
them in multi-threaded code like repair. Currently we're not,
but they should grow a larger warning comment.
> --- /dev/null
> +++ b/include/hlist.h
Why not add the hlist helpers to list.h, like in the kernel tree?
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-24 8:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 8:44 [PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2 Dave Chinner
2011-01-10 8:44 ` [PATCH 1/3] libxfs: reintroduce old xfs_repair radix-tree code Dave Chinner
2011-01-24 8:58 ` Christoph Hellwig
2011-02-09 18:05 ` Alex Elder
2011-02-14 0:36 ` Dave Chinner
2011-01-10 8:44 ` [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code Dave Chinner
2011-01-24 8:47 ` Christoph Hellwig [this message]
2011-01-24 23:47 ` Dave Chinner
2011-02-09 21:49 ` Alex Elder
2011-02-14 5:10 ` Dave Chinner
2011-02-14 5:31 ` Dave Chinner
2011-02-14 5:46 ` Dave Chinner
2011-01-10 8:44 ` [PATCH 3/3] libxfs: sync files " Dave Chinner
2011-01-24 8:57 ` Christoph Hellwig
2011-01-24 23:55 ` Dave Chinner
2011-02-10 19:02 ` Alex Elder
2011-02-14 6:30 ` [PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2 Dave Chinner
2011-02-22 20:45 ` Alex Elder
2011-03-07 18:14 ` Alex Elder
2011-03-07 18:24 ` Christoph Hellwig
2011-04-13 16:34 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124084732.GA4378@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox