From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id p0O90Use073627 for ; Mon, 24 Jan 2011 03:00:30 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5CCFB1A13523 for ; Mon, 24 Jan 2011 01:02:53 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id IdFyN9HupOqtifbZ for ; Mon, 24 Jan 2011 01:02:53 -0800 (PST) Date: Mon, 24 Jan 2011 04:02:52 -0500 From: Christoph Hellwig Subject: Re: [PATCH 2/5] xfs: limit extent length for allocation to AG size Message-ID: <20110124090252.GC26744@infradead.org> References: <1295411400-15614-1-git-send-email-david@fromorbit.com> <1295411400-15614-3-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1295411400-15614-3-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com > + /* > + * The requested extent can be larger than an AG, so trim the block > + * count back to the maximum sized extent in an AG. A typical empty AG > + * consumes 1 block for headers, 1 block for each btree root (3) and 4 > + * blocks for the free list. > + */ > + args.maxlen = MIN(ap->alen, mp->m_sb.sb_agblocks - 8); Maybe add a define for the over head blocks to document it more clearly? Otherwise looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs