From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/5] xfs: prevent extsize alignment from exceeding maximum extent size
Date: Mon, 24 Jan 2011 04:04:59 -0500 [thread overview]
Message-ID: <20110124090458.GD26744@infradead.org> (raw)
In-Reply-To: <1295411400-15614-4-git-send-email-david@fromorbit.com>
> + /*
> + * make sure we don't exceed a single
> + * extent length when we align the
> + * extent by reducing length we are
> + * going to allocate by the maximum
> + * amount extent size aligment may
> + * require.
> + alen = (xfs_extlen_t)XFS_FILBLKS_MIN(
> + len,
> + MAXEXTLEN - (2 * extsz - 1));
> + */
This essentially just adds a comment, given that the new code is inside
the bracing. Also the xfs_extlen_t cast seems pointless. The C type
promotion rules do just fine for going down from a 64bit type to a 32bit
one, as long as the results fit into the latter - which they always do
here.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-24 9:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 4:29 [PATCH 0/5] xfs: various 2.6.38 candidate bug fixes Dave Chinner
2011-01-19 4:29 ` [PATCH 1/5] xfs: speculative delayed allocation uses rounddown_power_of_2 badly Dave Chinner
2011-01-24 8:59 ` Christoph Hellwig
2011-01-19 4:29 ` [PATCH 2/5] xfs: limit extent length for allocation to AG size Dave Chinner
2011-01-24 9:02 ` Christoph Hellwig
2011-01-24 23:31 ` Dave Chinner
2011-01-19 4:29 ` [PATCH 3/5] xfs: prevent extsize alignment from exceeding maximum extent size Dave Chinner
2011-01-24 9:04 ` Christoph Hellwig [this message]
2011-01-24 23:32 ` Dave Chinner
2011-01-19 4:29 ` [PATCH 4/5] xfs: limit extsize to size of AGs and/or MAXEXTLEN Dave Chinner
2011-01-24 9:06 ` Christoph Hellwig
2011-01-24 23:37 ` Dave Chinner
2011-01-19 4:30 ` [PATCH 5/5] xfs: handle CIl transaction commit failures correctly Dave Chinner
2011-01-24 9:12 ` Christoph Hellwig
2011-01-24 23:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124090458.GD26744@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox