From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs: limit extsize to size of AGs and/or MAXEXTLEN
Date: Tue, 25 Jan 2011 10:37:35 +1100 [thread overview]
Message-ID: <20110124233735.GD11040@dastard> (raw)
In-Reply-To: <20110124090656.GE26744@infradead.org>
On Mon, Jan 24, 2011 at 04:06:56AM -0500, Christoph Hellwig wrote:
> On Wed, Jan 19, 2011 at 03:29:59PM +1100, Dave Chinner wrote:
> > + * Also, for non-realtime files, limit the extent size hint to
> > + * half the size of the AGs in the filesystem so alignment
> > + * doesn't result in extents larger than an AG.
>
> What do we do about the last AG, which potentionally is smaller than the
> others?
Not sure - I didn't actually consider that case because I forgot
about it.
At first glance it doesn't matter because it won't get
selected because the length of the AG is less than the requested
size unless it is the best match. If it is the best match, we can't
do extsize alignment anyway, so it's the same case as any other
allocation without a freespace extent large enough for alignment.
I'll do a bit more analysis, but I think we're OK here.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-24 23:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 4:29 [PATCH 0/5] xfs: various 2.6.38 candidate bug fixes Dave Chinner
2011-01-19 4:29 ` [PATCH 1/5] xfs: speculative delayed allocation uses rounddown_power_of_2 badly Dave Chinner
2011-01-24 8:59 ` Christoph Hellwig
2011-01-19 4:29 ` [PATCH 2/5] xfs: limit extent length for allocation to AG size Dave Chinner
2011-01-24 9:02 ` Christoph Hellwig
2011-01-24 23:31 ` Dave Chinner
2011-01-19 4:29 ` [PATCH 3/5] xfs: prevent extsize alignment from exceeding maximum extent size Dave Chinner
2011-01-24 9:04 ` Christoph Hellwig
2011-01-24 23:32 ` Dave Chinner
2011-01-19 4:29 ` [PATCH 4/5] xfs: limit extsize to size of AGs and/or MAXEXTLEN Dave Chinner
2011-01-24 9:06 ` Christoph Hellwig
2011-01-24 23:37 ` Dave Chinner [this message]
2011-01-19 4:30 ` [PATCH 5/5] xfs: handle CIl transaction commit failures correctly Dave Chinner
2011-01-24 9:12 ` Christoph Hellwig
2011-01-24 23:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124233735.GD11040@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox