From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] libxfs: sync files with 2.6.38 kernel code
Date: Tue, 25 Jan 2011 10:55:32 +1100 [thread overview]
Message-ID: <20110124235532.GG11040@dastard> (raw)
In-Reply-To: <20110124085751.GB4378@infradead.org>
On Mon, Jan 24, 2011 at 03:57:51AM -0500, Christoph Hellwig wrote:
> > +/* XXX: fix this up! */
> > #define OFF(f) bitize(offsetof(xfs_dinode_t, di_ ## f))
> > const field_t inode_flds[] = {
> > - { "core", FLDT_DINODE_CORE, OI(OFF(core)), C1, 0, TYP_NONE },
> > - { "next_unlinked", FLDT_AGINO, OI(OFF(next_unlinked)), C1, 0,
> > - TYP_INODE },
> > - { "u", FLDT_DINODE_U, OI(OFF(u)), C1, 0, TYP_NONE },
> > + { "core", FLDT_DINODE_CORE, OI(OFF(magic)), C1, 0, TYP_NONE },
> > + { "u", FLDT_DINODE_U, inode_u_offset, C1, FLD_OFFSET, TYP_NONE },
>
> I think the right way to fix this is to copy over all fields from
> the dinode core, and keep a "virtual" core field and the inode_core
> table for backwards compatiblity.
OK. By "virtual" core field, do you mean something like what I have
about, or something different?
> > + { "next_unlinked", FLDT_AGINO, OI(OFF(next_unlinked)), C1, 0,
> > + TYP_INODE },
>
> I think this one should only be added to the real dinode, not the core.
Good catch. I mixed up what was in xfs_icdinode and xfs_dinode
there.
>
> > #define XFS_BUF_LOCK 0
> > #define XFS_BUF_TRYLOCK 0
> > +#define XBF_LOCK XFS_BUF_LOCK
> > +#define XBF_TRYLOCK XFS_BUF_TRYLOCK
> > +#define XBF_DONT_BLOCK 0
>
> Please kill off the XFS_BUF_* flags, just like in kernelspace.
Will do.
Thanks for spending the time to look over these huge patches,
Christoph.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-24 23:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 8:44 [PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2 Dave Chinner
2011-01-10 8:44 ` [PATCH 1/3] libxfs: reintroduce old xfs_repair radix-tree code Dave Chinner
2011-01-24 8:58 ` Christoph Hellwig
2011-02-09 18:05 ` Alex Elder
2011-02-14 0:36 ` Dave Chinner
2011-01-10 8:44 ` [PATCH 2/3] libxlog: sync up with 2.6.38 kernel code Dave Chinner
2011-01-24 8:47 ` Christoph Hellwig
2011-01-24 23:47 ` Dave Chinner
2011-02-09 21:49 ` Alex Elder
2011-02-14 5:10 ` Dave Chinner
2011-02-14 5:31 ` Dave Chinner
2011-02-14 5:46 ` Dave Chinner
2011-01-10 8:44 ` [PATCH 3/3] libxfs: sync files " Dave Chinner
2011-01-24 8:57 ` Christoph Hellwig
2011-01-24 23:55 ` Dave Chinner [this message]
2011-02-10 19:02 ` Alex Elder
2011-02-14 6:30 ` [PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2 Dave Chinner
2011-02-22 20:45 ` Alex Elder
2011-03-07 18:14 ` Alex Elder
2011-03-07 18:24 ` Christoph Hellwig
2011-04-13 16:34 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110124235532.GG11040@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox