From: Dave Chinner <david@fromorbit.com>
To: Josef Bacik <josef@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Xfstests: make 014 only run on xfs
Date: Thu, 27 Jan 2011 11:59:45 +1100 [thread overview]
Message-ID: <20110127005945.GE21311@dastard> (raw)
In-Reply-To: <1296050729-17316-1-git-send-email-josef@redhat.com>
On Wed, Jan 26, 2011 at 09:05:29AM -0500, Josef Bacik wrote:
> This test relies on mounting with -o allocsize, which is an xfs specific mount
> option, so make the test only work on xfs. Thanks,
Oh, sorry, my fault. Perhaps something like this instead?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
xfstests: conditionalise allocsize option in 014
allocsize is an XFS specific mount option, and hence causes the test
to fail on other filesystems. Only set the mount option on xfs
filesystems.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
014 | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/014 b/014
index e6e0a6f..057e4d9 100755
--- a/014
+++ b/014
@@ -53,8 +53,10 @@ _setup_testdir
# ensure EOF preallocation doesn't massively extend the runtime of this test
# by limiting the amount of preallocation and therefore the amount of blocks
# zeroed during the truncfile test run.
-umount $TEST_DIR
-_test_mount -o allocsize=64k
+if [ "$FSTYP" == "xfs" ]; then
+ umount $TEST_DIR
+ _test_mount -o allocsize=64k
+fi
echo "brevity is wit..."
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-01-27 0:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 14:05 [PATCH] Xfstests: make 014 only run on xfs Josef Bacik
2011-01-26 16:56 ` Christoph Hellwig
2011-01-27 0:59 ` Dave Chinner [this message]
2011-02-01 23:48 ` Alex Elder
2011-02-02 0:58 ` Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127005945.GE21311@dastard \
--to=david@fromorbit.com \
--cc=josef@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox